Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove plugin template HLTJetTagWithMatching #42617

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

missirol
Copy link
Contributor

PR description:

This PR removes the plugin template HLTJetTagWithMatching, which is now superseded by the improved version of HLTJetTag added in #41351. The use of HLTJetTagWithMatching was removed from the latest Run-3 HLT menus in #42610. For further information, see also #41045, CMSHLT-2750, and CMSHLT-2863.

Merely technical. No changes expected.

PR validation:

addOnTests.py passed.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42617/36667

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/btau (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @Ming-Yan, @silviodonato, @AnnikaStein, @Senphy, @Martin-Grunewald, @JyothsnaKomaragiri, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d912c7/34388/summary.html
COMMIT: 564be66
CMSSW: CMSSW_13_3_X_2023-08-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42617/34388/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 21-Aug-2023 19:28:24 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin HLTPFJetTagWithMatching
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42617/34388/CMSSW_13_3_X_2023-08-21-1100/lib/el8_amd64_gcc11/poisoned/plugin-poisoned-HLTriggerbtauAuto.so because /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42617/34388/CMSSW_13_3_X_2023-08-21-1100/lib/el8_amd64_gcc11/poisoned/plugin-poisoned-HLTriggerbtauAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 21-Aug-2023 19:28:35 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin HLTPFJetTagWithMatching
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42617/34388/CMSSW_13_3_X_2023-08-21-1100/lib/el8_amd64_gcc11/poisoned/plugin-poisoned-HLTriggerbtauAuto.so because /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42617/34388/CMSSW_13_3_X_2023-08-21-1100/lib/el8_amd64_gcc11/poisoned/plugin-poisoned-HLTriggerbtauAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 21-Aug-2023 19:32:33 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin HLTPFJetTagWithMatching
Exception Message:
unable to load /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42617/34388/CMSSW_13_3_X_2023-08-21-1100/lib/el8_amd64_gcc11/poisoned/plugin-poisoned-HLTriggerbtauAuto.so because /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42617/34388/CMSSW_13_3_X_2023-08-21-1100/lib/el8_amd64_gcc11/poisoned/plugin-poisoned-HLTriggerbtauAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log
  • 20834.50120834.501_TTbar_14TeV+2026D88_Patatrack_PixelOnlyCPU/step2_TTbar_14TeV+2026D88_Patatrack_PixelOnlyCPU.log
  • 20834.50220834.502_TTbar_14TeV+2026D88_Patatrack_PixelOnlyGPU/step2_TTbar_14TeV+2026D88_Patatrack_PixelOnlyGPU.log
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42617/36674

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42617 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d912c7/34397/summary.html
COMMIT: a616cfc
CMSSW: CMSSW_13_3_X_2023-08-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42617/34397/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 11 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3152915
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3152893
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 44b1de6 into cms-sw:master Aug 22, 2023
@missirol missirol deleted the remove_hltJetTagWithMatching branch August 23, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants